Remove base::StringValue

Remove base::StringValue

As a follow-up to typedeffing base::StringValue to base::Value in
http://crrev.com/2516363005 this change replaces all references to
base::StringValue by base::Value.

TBR=stevenjb@chromium.org
BUG=646113
Review-Url: https://codereview.chromium.org/2664753002
Cr-Commit-Position: refs/heads/master@{#454848}
Committed: https://chromium.googlesource.com/chromium/src/+/122c4da76a70443fe965d1413741a79416a6e763

[jdoerrie, 2017-01-30 11:09:22]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 11:09:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 13:39:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 13:39:58]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-01-31 12:35:23]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 12:35:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 12:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 12:54:58]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[jdoerrie, 2017-01-31 14:02:11]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 14:02:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-01-31 14:15:21]

Description was changed from

==========
Remove StringValue

This change removes all mentions of |StringValue| from the codebase by replacing
it by |Value|.

BUG=646113
==========

to

==========
Remove base::StringValue

As a follow-up to typedeffing base::StringValue to base::Value in
http://crrev.com/2516363005 this change replaces all references to
base::StringValue by base::Value.

BUG=646113
==========

[jdoerrie, 2017-01-31 16:44:50]

jdoerrie@chromium.org changed reviewers:
+ brettw@chromium.org, stevenjb@chromium.org

[jdoerrie, 2017-01-31 16:54:42]

jdoerrie@chromium.org changed reviewers:
- stevenjb@chromium.org

[commit-bot: I haz the power, 2017-01-31 18:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 18:43:22]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-02-02 09:51:53]

Summary of Changes
- Similarly to http://crrev.com/2666093002  the vast majority of changes are a
  simple search and replace, executed via
  `sed -i "s/\bbase::StringValue\b/base::Value/g"`

- A manual inspection of remaining occurrences of |StringValue| followed.
  Most of them were usages within the |base| namespace and were also changed.
  Furthermore, now redundant typedefs to |Value| are removed,
  for example in base/test/values_test_util.h

- The remaining occurrences of StringValue in C++ files can be classified as
  follows:

  - References to google::protobuf::StringValue:
    - third_party/protobuf/objectivec/google/protobuf/Wrappers.pbobjc.h
    -
third_party/protobuf/src/google/protobuf/util/internal/protostream_objectwriter.cc
    -
third_party/protobuf/src/google/protobuf/util/internal/protostream_objectsource.cc
    - third_party/protobuf/src/google/protobuf/util/internal/utility.cc
    - third_party/protobuf/src/google/protobuf/wrappers.pb.h
    - third_party/protobuf/src/google/protobuf/wrappers.pb.cc

  - References to blink::XPath::Value::StringValue:
    - third_party/WebKit/Source/core/xml/XPathResult.cpp
    - third_party/WebKit/Source/core/xml/XPathPredicate.h
    - third_party/WebKit/Source/core/xml/XPathFunctions.cpp
    - third_party/WebKit/Source/core/xml/XPathValue.cpp
    - third_party/WebKit/Source/core/xml/XPathValue.h

  - References to blink::protocol::StringValue:
    - third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
    - third_party/WebKit/Source/web/InspectorOverlay.cpp
    - third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp
    -
third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp
    -
third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp
    - content/browser/devtools/protocol_string.cc

  - References to blink::SQLValue::StringValue:
    - third_party/WebKit/Source/bindings/modules/v8/ToV8ForModules.h
    - third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp
    - third_party/WebKit/Source/modules/webdatabase/sqlite/SQLValue.cpp
    - third_party/WebKit/Source/modules/webdatabase/sqlite/SQLValue.h

  - As part of Clang Value Cleanup:
    - tools/clang/value_cleanup/ListValueRewriter.cpp
    - tools/clang/value_cleanup/tests/values.h

  - Usages in comments, variable names and string literals:
    - chromeos/network/onc/onc_mapper.h
    - net/log/net_log.h
    - sql/meta_table_unittest.cc
    -
chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win_unittest.cc
    - components/json_schema/json_schema_validator.cc
    - components/user_prefs/tracked/hash_store_contents.h
    - components/user_prefs/tracked/pref_hash_store_transaction.h
    - components/drive/chromeos/file_system_interface.h
    - components/sync/syncable/syncable_id.h
    - components/sync/test/fake_server/fake_server.h
    - components/test_runner/web_ax_object_proxy.cc
    - components/test_runner/web_ax_object_proxy.h
    - components/flags_ui/flags_state.cc
    - components/policy/core/common/configuration_policy_provider_test.cc
    - base/trace_event/trace_event_memory_overhead.cc
    - base/win/registry_unittest.cc
    - base/values_unittest.cc
    - base/json/json_parser.cc
    - extensions/browser/api/declarative/declarative_api.cc
    - extensions/browser/api/web_request/upload_data_presenter.h
    -
extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

[brettw, 2017-02-07 00:13:13]

Checked base, spot-checked the rest. LGTM

[jdoerrie, 2017-03-02 15:34:52]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 15:35:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-03-02 15:46:05]

Description was changed from

==========
Remove base::StringValue

As a follow-up to typedeffing base::StringValue to base::Value in
http://crrev.com/2516363005 this change replaces all references to
base::StringValue by base::Value.

BUG=646113
==========

to

==========
Remove base::StringValue

As a follow-up to typedeffing base::StringValue to base::Value in
http://crrev.com/2516363005 this change replaces all references to
base::StringValue by base::Value.

TBR=stevenjb@chromium.org
BUG=646113
==========

[jdoerrie, 2017-03-02 15:46:05]

jdoerrie@chromium.org changed reviewers:
+ rsesek@chromium.org, stevenjb@chromium.org

[jdoerrie, 2017-03-02 15:51:43]

rsesek@, please review:
- components/arc/bluetooth/bluetooth_type_converters_unittest.cc
- content/common/common_param_traits_unittest.cc
- mojo/common/values_struct_traits.cc

For the rest I am using TBR, because this change is largely mechanical, brettw@
already gave his LGTM and the effort was published on chromium-dev in
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/qWyLUZklfCk...

stevenjb@, TBR for:
- chrome/browser/ui/webui/options/*
- chromeos/network/*

[Robert Sesek, 2017-03-02 16:10:45]

lgtm

[commit-bot: I haz the power, 2017-03-02 18:13:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 18:13:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[jdoerrie, 2017-03-06 08:19:58]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 08:20:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 10:46:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 10:46:20]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-03-06 10:55:05]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2017-03-06 10:55:07]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/2664753002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-06 10:55:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 11:12:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488797705920280,
"parent_rev": "d8e518533a6a987997cdcf438ddc21573eb75de0", "commit_rev":
"122c4da76a70443fe965d1413741a79416a6e763"}

[commit-bot: I haz the power, 2017-03-06 11:12:53]

Description was changed from

==========
Remove base::StringValue

As a follow-up to typedeffing base::StringValue to base::Value in
http://crrev.com/2516363005 this change replaces all references to
base::StringValue by base::Value.

TBR=stevenjb@chromium.org
BUG=646113
==========

to

==========
Remove base::StringValue

As a follow-up to typedeffing base::StringValue to base::Value in
http://crrev.com/2516363005 this change replaces all references to
base::StringValue by base::Value.

TBR=stevenjb@chromium.org
BUG=646113

Review-Url: https://codereview.chromium.org/2664753002
Cr-Commit-Position: refs/heads/master@{#454848}
Committed:
https://chromium.googlesource.com/chromium/src/+/122c4da76a70443fe965d1413741...
==========

[commit-bot: I haz the power, 2017-03-06 11:13:00]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/122c4da76a70443fe965d1413741...