Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: chrome/browser/ui/webui/settings/search_engines_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/search_engines_handler.cc
diff --git a/chrome/browser/ui/webui/settings/search_engines_handler.cc b/chrome/browser/ui/webui/settings/search_engines_handler.cc
index 53534e35081bfb2973302b3764ee205cf0567dfa..d5f70c772ee88b7d598a35e63f9f545c07693220 100644
--- a/chrome/browser/ui/webui/settings/search_engines_handler.cc
+++ b/chrome/browser/ui/webui/settings/search_engines_handler.cc
@@ -195,11 +195,11 @@ SearchEnginesHandler::GetSearchEnginesList() {
void SearchEnginesHandler::OnModelChanged() {
AllowJavascript();
CallJavascriptFunction("cr.webUIListenerCallback",
- base::StringValue("search-engines-changed"),
+ base::Value("search-engines-changed"),
*GetSearchEnginesList());
// Google Now availability may have changed.
CallJavascriptFunction("cr.webUIListenerCallback",
- base::StringValue("google-now-availability-changed"),
+ base::Value("google-now-availability-changed"),
base::Value(IsGoogleNowAvailable(profile_)));
}
@@ -518,7 +518,7 @@ void SearchEnginesHandler::HotwordInfoComplete(
ResolveJavascriptCallback(*callback_id, status);
} else {
CallJavascriptFunction("cr.webUIListenerCallback",
- base::StringValue("hotword-info-update"), status);
+ base::Value("hotword-info-update"), status);
}
}

Powered by Google App Engine
This is Rietveld 408576698