chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc ('k') | chrome/browser/ssl/chrome_expect_ct_reporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

index ec2c18fdf4a75b584e64128c082e7411771d4057..7eb3d964737b310bce418ce0aa56326bbd7d7b9d 100644

--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

@@ -139,7 +139,7 @@ class PreferenceValidationDelegateValues

case Value::Type::DOUBLE:

return std::unique_ptr<Value>(new base::Value(0.47));

case Value::Type::STRING:

- return std::unique_ptr<Value>(new base::StringValue("i have a spleen"));

+ return std::unique_ptr<Value>(new base::Value("i have a spleen"));

case Value::Type::DICTIONARY: {

std::unique_ptr<base::DictionaryValue> value(

new base::DictionaryValue());