chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | chrome/browser/ui/webui/sync_internals_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

diff --git a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

index 57872aaca994ccba7f1328e214c70c337a802f16..2bd61444adbb9a5a4c893beb566aba55e9d69d98 100644

--- a/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

+++ b/chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_handler.cc

@@ -86,7 +86,7 @@ void SyncFileSystemInternalsHandler::OnSyncStateUpdated(

// TODO(calvinlo): OnSyncStateUpdated should be updated to also provide the

// notification mechanism (XMPP or Polling).

web_ui()->CallJavascriptFunctionUnsafe("SyncService.onGetServiceStatus",

- base::StringValue(state_string));

+ base::Value(state_string));

}

void SyncFileSystemInternalsHandler::OnFileSynced(

@@ -121,7 +121,7 @@ void SyncFileSystemInternalsHandler::GetServiceStatus(

const std::string state_string = extensions::api::sync_file_system::ToString(

extensions::SyncServiceStateToExtensionEnum(state_enum));

web_ui()->CallJavascriptFunctionUnsafe("SyncService.onGetServiceStatus",

- base::StringValue(state_string));

+ base::Value(state_string));

}

void SyncFileSystemInternalsHandler::GetNotificationSource(

@@ -132,9 +132,8 @@ void SyncFileSystemInternalsHandler::GetNotificationSource(

return;

bool xmpp_enabled = drive_notification_manager->push_notification_enabled();

std::string notification_source = xmpp_enabled ? "XMPP" : "Polling";

- web_ui()->CallJavascriptFunctionUnsafe(

- "SyncService.onGetNotificationSource",

- base::StringValue(notification_source));

+ web_ui()->CallJavascriptFunctionUnsafe("SyncService.onGetNotificationSource",

+ base::Value(notification_source));

}

void SyncFileSystemInternalsHandler::GetLog(