Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/password_manager_handler.h" 5 #include "chrome/browser/ui/webui/options/password_manager_handler.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 } 240 }
241 241
242 void PasswordManagerHandler::ShowPassword( 242 void PasswordManagerHandler::ShowPassword(
243 size_t index, 243 size_t index,
244 const std::string& origin_url, 244 const std::string& origin_url,
245 const std::string& username, 245 const std::string& username,
246 const base::string16& password_value) { 246 const base::string16& password_value) {
247 // Call back the front end to reveal the password. 247 // Call back the front end to reveal the password.
248 web_ui()->CallJavascriptFunctionUnsafe("PasswordManager.showPassword", 248 web_ui()->CallJavascriptFunctionUnsafe("PasswordManager.showPassword",
249 base::Value(static_cast<int>(index)), 249 base::Value(static_cast<int>(index)),
250 base::StringValue(password_value)); 250 base::Value(password_value));
251 } 251 }
252 252
253 void PasswordManagerHandler::HandleUpdatePasswordLists( 253 void PasswordManagerHandler::HandleUpdatePasswordLists(
254 const base::ListValue* args) { 254 const base::ListValue* args) {
255 password_manager_presenter_->UpdatePasswordLists(); 255 password_manager_presenter_->UpdatePasswordLists();
256 } 256 }
257 257
258 void PasswordManagerHandler::SetPasswordList( 258 void PasswordManagerHandler::SetPasswordList(
259 const std::vector<std::unique_ptr<autofill::PasswordForm>>& password_list) { 259 const std::vector<std::unique_ptr<autofill::PasswordForm>>& password_list) {
260 base::ListValue entries; 260 base::ListValue entries;
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 password_manager_presenter_->GetAllPasswords(); 398 password_manager_presenter_->GetAllPasswords();
399 UMA_HISTOGRAM_COUNTS("PasswordManager.ExportedPasswordsPerUserInCSV", 399 UMA_HISTOGRAM_COUNTS("PasswordManager.ExportedPasswordsPerUserInCSV",
400 password_list.size()); 400 password_list.size());
401 password_manager::PasswordExporter::Export( 401 password_manager::PasswordExporter::Export(
402 path, password_list, content::BrowserThread::GetTaskRunnerForThread( 402 path, password_list, content::BrowserThread::GetTaskRunnerForThread(
403 content::BrowserThread::FILE) 403 content::BrowserThread::FILE)
404 .get()); 404 .get());
405 } 405 }
406 406
407 } // namespace options 407 } // namespace options
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698