chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc ('k') | chrome/browser/chromeos/preferences_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

index 637bc2be656675fa68200bc082ae74cfbff5e7fa..e031a8dda70eb2cd4cbaf5f83813d10b7ba35299 100644

--- a/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

+++ b/chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc

@@ -122,7 +122,7 @@ class UserCloudPolicyStoreChromeOSTest : public testing::Test {

const PolicyMap::Entry* entry =

store_->policy_map().Get(key::kHomepageLocation);

ASSERT_TRUE(entry);

- EXPECT_TRUE(base::StringValue(expected_value).Equals(entry->value.get()));

+ EXPECT_TRUE(base::Value(expected_value).Equals(entry->value.get()));

}

void StoreUserPolicyKey(const std::string& public_key) {

@@ -158,7 +158,7 @@ class UserCloudPolicyStoreChromeOSTest : public testing::Test {

if (previous_value) {

previous_policy.Set(key::kHomepageLocation, POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

- base::MakeUnique<base::StringValue>(previous_value),

+ base::MakeUnique<base::Value>(previous_value),

nullptr);

}

EXPECT_TRUE(previous_policy.Equals(store_->policy_map()));