components/user_prefs/tracked/pref_hash_store_impl.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/user_prefs/tracked/pref_hash_store_impl.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/user_prefs/tracked/pref_hash_store_impl.cc

diff --git a/components/user_prefs/tracked/pref_hash_store_impl.cc b/components/user_prefs/tracked/pref_hash_store_impl.cc

index bb920ca4c98fdcf7707952d7b4079be3e1b2b9bd..6487822fdb1df7671f5971a5c90de4a9bbb56027 100644

--- a/components/user_prefs/tracked/pref_hash_store_impl.cc

+++ b/components/user_prefs/tracked/pref_hash_store_impl.cc

@@ -271,7 +271,7 @@ void PrefHashStoreImpl::PrefHashStoreTransactionImpl::StoreSplitHash(

for (base::DictionaryValue::Iterator it(*split_macs); !it.IsAtEnd();

it.Advance()) {

- const base::StringValue* value_as_string;

+ const base::Value* value_as_string;

bool is_string = it.value().GetAsString(&value_as_string);

DCHECK(is_string);