chrome/browser/devtools/devtools_window.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index 1fe197874771587c716f21fb5cea56f91853f46b..e27d75baca923bad50827cb137dc6df58ebc7e23 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -1352,7 +1352,7 @@ void DevToolsWindow::DoAction(const DevToolsToggleAction& action) {

const DevToolsToggleAction::RevealParams* params =

action.params();

CHECK(params);

- base::StringValue url_value(params->url);

+ base::Value url_value(params->url);

base::Value line_value(static_cast<int>(params->line_number));

base::Value column_value(static_cast<int>(params->column_number));

bindings_->CallClientFunction("DevToolsAPI.revealSourceLine",