Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: components/ntp_tiles/webui/popular_sites_internals_message_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/login/screens/screen_context.cc ('k') | components/ownership/owner_settings_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_tiles/webui/popular_sites_internals_message_handler.cc
diff --git a/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc b/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc
index 29e69b93eb4342da81c1ead499cb8ad5a71cb8b0..7163b59fd8897dddd0fe771f1bbb73e7843c583a 100644
--- a/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc
+++ b/components/ntp_tiles/webui/popular_sites_internals_message_handler.cc
@@ -114,12 +114,12 @@ void PopularSitesInternalsMessageHandler::SendOverrides() {
std::string version =
prefs->GetString(ntp_tiles::prefs::kPopularSitesOverrideVersion);
web_ui_->CallJavascriptFunction(
- "chrome.popular_sites_internals.receiveOverrides", base::StringValue(url),
- base::StringValue(country), base::StringValue(version));
+ "chrome.popular_sites_internals.receiveOverrides", base::Value(url),
+ base::Value(country), base::Value(version));
}
void PopularSitesInternalsMessageHandler::SendDownloadResult(bool success) {
- base::StringValue result(success ? "Success" : "Fail");
+ base::Value result(success ? "Success" : "Fail");
web_ui_->CallJavascriptFunction(
"chrome.popular_sites_internals.receiveDownloadResult", result);
}
@@ -142,7 +142,7 @@ void PopularSitesInternalsMessageHandler::SendSites() {
void PopularSitesInternalsMessageHandler::SendJson(const std::string& json) {
web_ui_->CallJavascriptFunction("chrome.popular_sites_internals.receiveJson",
- base::StringValue(json));
+ base::Value(json));
}
void PopularSitesInternalsMessageHandler::OnPopularSitesAvailable(
« no previous file with comments | « components/login/screens/screen_context.cc ('k') | components/ownership/owner_settings_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698