Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: extensions/renderer/activity_log_converter_strategy.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/value_builder.cc ('k') | extensions/renderer/argument_spec.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/activity_log_converter_strategy.cc
diff --git a/extensions/renderer/activity_log_converter_strategy.cc b/extensions/renderer/activity_log_converter_strategy.cc
index 1be41aa27cdc8f417eda512707238d8e139c54c9..443535f8247d94422f10d6a9db4d38dc1df6b4b0 100644
--- a/extensions/renderer/activity_log_converter_strategy.cc
+++ b/extensions/renderer/activity_log_converter_strategy.cc
@@ -40,11 +40,11 @@ std::unique_ptr<base::Value> SummarizeV8Value(v8::Isolate* isolate,
if (try_catch.HasCaught()) {
return std::unique_ptr<base::Value>(
- new base::StringValue("[JS Execution Exception]"));
+ new base::Value("[JS Execution Exception]"));
}
return std::unique_ptr<base::Value>(
- new base::StringValue(std::string(*v8::String::Utf8Value(name))));
+ new base::Value(std::string(*v8::String::Utf8Value(name))));
}
} // namespace
« no previous file with comments | « extensions/common/value_builder.cc ('k') | extensions/renderer/argument_spec.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698