Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: components/policy/core/common/proxy_policy_provider_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/proxy_policy_provider_unittest.cc
diff --git a/components/policy/core/common/proxy_policy_provider_unittest.cc b/components/policy/core/common/proxy_policy_provider_unittest.cc
index 254074d51cff50d1d819f86649d3d84338e98fbf..1b57eb574a60217e7b903eb3ac422582eb0a67ec 100644
--- a/components/policy/core/common/proxy_policy_provider_unittest.cc
+++ b/components/policy/core/common/proxy_policy_provider_unittest.cc
@@ -55,7 +55,7 @@ TEST_F(ProxyPolicyProviderTest, Delegate) {
PolicyBundle bundle;
bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD, base::MakeUnique<base::StringValue>("value"),
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("value"),
nullptr);
mock_provider_.UpdatePolicy(CopyBundle(bundle));
@@ -67,8 +67,8 @@ TEST_F(ProxyPolicyProviderTest, Delegate) {
EXPECT_CALL(observer_, OnUpdatePolicy(&proxy_provider_));
bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
.Set("policy", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>("new value"), nullptr);
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("new value"),
+ nullptr);
mock_provider_.UpdatePolicy(CopyBundle(bundle));
Mock::VerifyAndClearExpectations(&observer_);
EXPECT_TRUE(bundle.Equals(proxy_provider_.policies()));
« no previous file with comments | « components/policy/core/common/preg_parser_unittest.cc ('k') | components/policy/core/common/registry_dict.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698