Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: components/prefs/pref_change_registrar_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/prefs/json_pref_store_unittest.cc ('k') | components/prefs/pref_registry_simple.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/bind_helpers.h" 6 #include "base/bind_helpers.h"
7 #include "components/prefs/pref_change_registrar.h" 7 #include "components/prefs/pref_change_registrar.h"
8 #include "components/prefs/pref_observer.h" 8 #include "components/prefs/pref_observer.h"
9 #include "components/prefs/pref_registry_simple.h" 9 #include "components/prefs/pref_registry_simple.h"
10 #include "components/prefs/testing_pref_service.h" 10 #include "components/prefs/testing_pref_service.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 TEST_F(ObserveSetOfPreferencesTest, IsObserved) { 150 TEST_F(ObserveSetOfPreferencesTest, IsObserved) {
151 std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar()); 151 std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar());
152 EXPECT_TRUE(pref_set->IsObserved(kHomePage)); 152 EXPECT_TRUE(pref_set->IsObserved(kHomePage));
153 EXPECT_TRUE(pref_set->IsObserved(kHomePageIsNewTabPage)); 153 EXPECT_TRUE(pref_set->IsObserved(kHomePageIsNewTabPage));
154 EXPECT_FALSE(pref_set->IsObserved(kApplicationLocale)); 154 EXPECT_FALSE(pref_set->IsObserved(kApplicationLocale));
155 } 155 }
156 156
157 TEST_F(ObserveSetOfPreferencesTest, IsManaged) { 157 TEST_F(ObserveSetOfPreferencesTest, IsManaged) {
158 std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar()); 158 std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar());
159 EXPECT_FALSE(pref_set->IsManaged()); 159 EXPECT_FALSE(pref_set->IsManaged());
160 pref_service_->SetManagedPref(kHomePage, 160 pref_service_->SetManagedPref(kHomePage, new Value("http://crbug.com"));
161 new StringValue("http://crbug.com"));
162 EXPECT_TRUE(pref_set->IsManaged()); 161 EXPECT_TRUE(pref_set->IsManaged());
163 pref_service_->SetManagedPref(kHomePageIsNewTabPage, new Value(true)); 162 pref_service_->SetManagedPref(kHomePageIsNewTabPage, new Value(true));
164 EXPECT_TRUE(pref_set->IsManaged()); 163 EXPECT_TRUE(pref_set->IsManaged());
165 pref_service_->RemoveManagedPref(kHomePage); 164 pref_service_->RemoveManagedPref(kHomePage);
166 EXPECT_TRUE(pref_set->IsManaged()); 165 EXPECT_TRUE(pref_set->IsManaged());
167 pref_service_->RemoveManagedPref(kHomePageIsNewTabPage); 166 pref_service_->RemoveManagedPref(kHomePageIsNewTabPage);
168 EXPECT_FALSE(pref_set->IsManaged()); 167 EXPECT_FALSE(pref_set->IsManaged());
169 } 168 }
170 169
171 TEST_F(ObserveSetOfPreferencesTest, Observe) { 170 TEST_F(ObserveSetOfPreferencesTest, Observe) {
172 using testing::_; 171 using testing::_;
173 using testing::Mock; 172 using testing::Mock;
174 173
175 PrefChangeRegistrar pref_set; 174 PrefChangeRegistrar pref_set;
176 PrefChangeRegistrar::NamedChangeCallback callback = base::Bind( 175 PrefChangeRegistrar::NamedChangeCallback callback = base::Bind(
177 &ObserveSetOfPreferencesTest::OnPreferenceChanged, 176 &ObserveSetOfPreferencesTest::OnPreferenceChanged,
178 base::Unretained(this)); 177 base::Unretained(this));
179 pref_set.Init(pref_service_.get()); 178 pref_set.Init(pref_service_.get());
180 pref_set.Add(kHomePage, callback); 179 pref_set.Add(kHomePage, callback);
181 pref_set.Add(kHomePageIsNewTabPage, callback); 180 pref_set.Add(kHomePageIsNewTabPage, callback);
182 181
183 EXPECT_CALL(*this, OnPreferenceChanged(kHomePage)); 182 EXPECT_CALL(*this, OnPreferenceChanged(kHomePage));
184 pref_service_->SetUserPref(kHomePage, new StringValue("http://crbug.com")); 183 pref_service_->SetUserPref(kHomePage, new Value("http://crbug.com"));
185 Mock::VerifyAndClearExpectations(this); 184 Mock::VerifyAndClearExpectations(this);
186 185
187 EXPECT_CALL(*this, OnPreferenceChanged(kHomePageIsNewTabPage)); 186 EXPECT_CALL(*this, OnPreferenceChanged(kHomePageIsNewTabPage));
188 pref_service_->SetUserPref(kHomePageIsNewTabPage, new Value(true)); 187 pref_service_->SetUserPref(kHomePageIsNewTabPage, new Value(true));
189 Mock::VerifyAndClearExpectations(this); 188 Mock::VerifyAndClearExpectations(this);
190 189
191 EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0); 190 EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0);
192 pref_service_->SetUserPref(kApplicationLocale, new StringValue("en_US.utf8")); 191 pref_service_->SetUserPref(kApplicationLocale, new Value("en_US.utf8"));
193 Mock::VerifyAndClearExpectations(this); 192 Mock::VerifyAndClearExpectations(this);
194 } 193 }
195 194
196 } // namespace base 195 } // namespace base
OLDNEW
« no previous file with comments | « components/prefs/json_pref_store_unittest.cc ('k') | components/prefs/pref_registry_simple.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698