Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: components/sync/syncable/model_type.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/syncable/entry_kernel.cc ('k') | components/sync/syncable/model_type_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/syncable/model_type.cc
diff --git a/components/sync/syncable/model_type.cc b/components/sync/syncable/model_type.cc
index 9c404a57f3e4e3536ccf262135f232f714e10c94..b222cd65bab6ab7552cc8a30b1c48351fee8c9d4 100644
--- a/components/sync/syncable/model_type.cc
+++ b/components/sync/syncable/model_type.cc
@@ -553,16 +553,16 @@ int ModelTypeToHistogramInt(ModelType model_type) {
return 0;
}
-base::StringValue* ModelTypeToValue(ModelType model_type) {
+base::Value* ModelTypeToValue(ModelType model_type) {
if (model_type >= FIRST_REAL_MODEL_TYPE) {
- return new base::StringValue(ModelTypeToString(model_type));
+ return new base::Value(ModelTypeToString(model_type));
} else if (model_type == TOP_LEVEL_FOLDER) {
- return new base::StringValue("Top-level folder");
+ return new base::Value("Top-level folder");
} else if (model_type == UNSPECIFIED) {
- return new base::StringValue("Unspecified");
+ return new base::Value("Unspecified");
}
NOTREACHED();
- return new base::StringValue(std::string());
+ return new base::Value(std::string());
}
ModelType ModelTypeFromValue(const base::Value& value) {
« no previous file with comments | « components/sync/syncable/entry_kernel.cc ('k') | components/sync/syncable/model_type_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698