Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/test/chromedriver/window_commands.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | chromeos/dbus/fake_shill_device_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/window_commands.cc
diff --git a/chrome/test/chromedriver/window_commands.cc b/chrome/test/chromedriver/window_commands.cc
index 5aa83bc117b884ec0f2e9ee954f21a1336c245c2..7444d47b9d42237f92fe335733bbdeee08d56401 100644
--- a/chrome/test/chromedriver/window_commands.cc
+++ b/chrome/test/chromedriver/window_commands.cc
@@ -486,7 +486,7 @@ Status ExecuteGetCurrentUrl(Session* session,
return status;
}
}
- value->reset(new base::StringValue(url));
+ value->reset(new base::Value(url));
return Status(kOk);
}
@@ -885,7 +885,7 @@ Status ExecuteScreenshot(Session* session,
if (status.IsError())
return status;
- value->reset(new base::StringValue(screenshot));
+ value->reset(new base::Value(screenshot));
return Status(kOk);
}
« no previous file with comments | « chrome/test/chromedriver/session_commands.cc ('k') | chromeos/dbus/fake_shill_device_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698