Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/common/custom_handlers/protocol_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/custom_handlers/protocol_handler.h" 5 #include "chrome/common/custom_handlers/protocol_handler.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "net/base/escape.h" 10 #include "net/base/escape.h"
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 54
55 GURL ProtocolHandler::TranslateUrl(const GURL& url) const { 55 GURL ProtocolHandler::TranslateUrl(const GURL& url) const {
56 std::string translatedUrlSpec(url_.spec()); 56 std::string translatedUrlSpec(url_.spec());
57 base::ReplaceSubstringsAfterOffset(&translatedUrlSpec, 0, "%s", 57 base::ReplaceSubstringsAfterOffset(&translatedUrlSpec, 0, "%s",
58 net::EscapeQueryParamValue(url.spec(), true)); 58 net::EscapeQueryParamValue(url.spec(), true));
59 return GURL(translatedUrlSpec); 59 return GURL(translatedUrlSpec);
60 } 60 }
61 61
62 std::unique_ptr<base::DictionaryValue> ProtocolHandler::Encode() const { 62 std::unique_ptr<base::DictionaryValue> ProtocolHandler::Encode() const {
63 auto d = base::MakeUnique<base::DictionaryValue>(); 63 auto d = base::MakeUnique<base::DictionaryValue>();
64 d->Set("protocol", new base::StringValue(protocol_)); 64 d->Set("protocol", new base::Value(protocol_));
65 d->Set("url", new base::StringValue(url_.spec())); 65 d->Set("url", new base::Value(url_.spec()));
66 return d; 66 return d;
67 } 67 }
68 68
69 #if !defined(NDEBUG) 69 #if !defined(NDEBUG)
70 std::string ProtocolHandler::ToString() const { 70 std::string ProtocolHandler::ToString() const {
71 return "{ protocol=" + protocol_ + 71 return "{ protocol=" + protocol_ +
72 ", url=" + url_.spec() + 72 ", url=" + url_.spec() +
73 " }"; 73 " }";
74 } 74 }
75 #endif 75 #endif
76 76
77 bool ProtocolHandler::operator==(const ProtocolHandler& other) const { 77 bool ProtocolHandler::operator==(const ProtocolHandler& other) const {
78 return protocol_ == other.protocol_ && url_ == other.url_; 78 return protocol_ == other.protocol_ && url_ == other.url_;
79 } 79 }
80 80
81 bool ProtocolHandler::IsEquivalent(const ProtocolHandler& other) const { 81 bool ProtocolHandler::IsEquivalent(const ProtocolHandler& other) const {
82 return protocol_ == other.protocol_ && url_ == other.url_; 82 return protocol_ == other.protocol_ && url_ == other.url_;
83 } 83 }
84 84
85 bool ProtocolHandler::operator<(const ProtocolHandler& other) const { 85 bool ProtocolHandler::operator<(const ProtocolHandler& other) const {
86 return url_ < other.url_; 86 return url_ < other.url_;
87 } 87 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/welcome_win10_handler.cc ('k') | chrome/common/extensions/manifest_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698