ipc/ipc_message_utils_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_utils_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_message_utils_unittest.cc

diff --git a/ipc/ipc_message_utils_unittest.cc b/ipc/ipc_message_utils_unittest.cc

index dae86758dbe3a57e02f6eeb28cad4179d0cf5aaa..36b0dbddc4983de52ce15025fc31dc7fe8fe108a 100644

--- a/ipc/ipc_message_utils_unittest.cc

+++ b/ipc/ipc_message_utils_unittest.cc

@@ -99,7 +99,7 @@ TEST(IPCMessageUtilsTest, ValueSize) {

std::unique_ptr<base::DictionaryValue> value(new base::DictionaryValue);

value->SetWithoutPathExpansion("foo", new base::Value(42));

value->SetWithoutPathExpansion("bar", new base::Value(3.14));

- value->SetWithoutPathExpansion("baz", new base::StringValue("hello"));

+ value->SetWithoutPathExpansion("baz", new base::Value("hello"));

value->SetWithoutPathExpansion("qux", base::Value::CreateNullValue());

std::unique_ptr<base::DictionaryValue> nested_dict(new base::DictionaryValue);

« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | mojo/common/common_custom_types_unittest.cc » ('j') | no next file with comments »