device/bluetooth/dbus/bluetooth_device_client.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_device_client.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: device/bluetooth/dbus/bluetooth_device_client.cc

diff --git a/device/bluetooth/dbus/bluetooth_device_client.cc b/device/bluetooth/dbus/bluetooth_device_client.cc

index 09b66e1cfe642122b04c8536d273df2255aa12c5..53199eba4bba82a338b6b40452885db0285c9c53 100644

--- a/device/bluetooth/dbus/bluetooth_device_client.cc

+++ b/device/bluetooth/dbus/bluetooth_device_client.cc

@@ -87,7 +87,7 @@ std::unique_ptr<BluetoothServiceAttributeValueBlueZ> ReadAttributeValue(

std::string str;

if (!struct_reader->PopVariantOfString(&str))

return nullptr;

- value = base::MakeUnique<base::StringValue>(str);

+ value = base::MakeUnique<base::Value>(str);

break;

}

case bluez::BluetoothServiceAttributeValueBlueZ::BOOL: {