Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: chrome/browser/ui/webui/media/webrtc_logs_ui.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/media/webrtc_logs_ui.h" 5 #include "chrome/browser/ui/webui/media/webrtc_logs_ui.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 // If we haven't set |value_w| above, we fall back on the upload time, which 195 // If we haven't set |value_w| above, we fall back on the upload time, which
196 // was already in the variable. In case it's empty set the string to 196 // was already in the variable. In case it's empty set the string to
197 // inform that the time is unknown. 197 // inform that the time is unknown.
198 if (value_w.empty()) 198 if (value_w.empty())
199 value_w = base::string16(base::ASCIIToUTF16("(unknown time)")); 199 value_w = base::string16(base::ASCIIToUTF16("(unknown time)"));
200 upload->SetString("capture_time", value_w); 200 upload->SetString("capture_time", value_w);
201 201
202 upload_list.Append(std::move(upload)); 202 upload_list.Append(std::move(upload));
203 } 203 }
204 204
205 base::StringValue version(version_info::GetVersionNumber()); 205 base::Value version(version_info::GetVersionNumber());
206 206
207 web_ui()->CallJavascriptFunctionUnsafe("updateWebRtcLogsList", upload_list, 207 web_ui()->CallJavascriptFunctionUnsafe("updateWebRtcLogsList", upload_list,
208 version); 208 version);
209 } 209 }
210 210
211 } // namespace 211 } // namespace
212 212
213 /////////////////////////////////////////////////////////////////////////////// 213 ///////////////////////////////////////////////////////////////////////////////
214 // 214 //
215 // WebRtcLogsUI 215 // WebRtcLogsUI
216 // 216 //
217 /////////////////////////////////////////////////////////////////////////////// 217 ///////////////////////////////////////////////////////////////////////////////
218 218
219 WebRtcLogsUI::WebRtcLogsUI(content::WebUI* web_ui) : WebUIController(web_ui) { 219 WebRtcLogsUI::WebRtcLogsUI(content::WebUI* web_ui) : WebUIController(web_ui) {
220 Profile* profile = Profile::FromWebUI(web_ui); 220 Profile* profile = Profile::FromWebUI(web_ui);
221 web_ui->AddMessageHandler(base::MakeUnique<WebRtcLogsDOMHandler>(profile)); 221 web_ui->AddMessageHandler(base::MakeUnique<WebRtcLogsDOMHandler>(profile));
222 222
223 // Set up the chrome://webrtc-logs/ source. 223 // Set up the chrome://webrtc-logs/ source.
224 content::WebUIDataSource::Add(profile, CreateWebRtcLogsUIHTMLSource()); 224 content::WebUIDataSource::Add(profile, CreateWebRtcLogsUIHTMLSource());
225 } 225 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698