Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/declarative_webrequest/webrequest_condition_att ribute.h" 5 #include "extensions/browser/api/declarative_webrequest/webrequest_condition_att ribute.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <utility> 10 #include <utility>
(...skipping 17 matching lines...) Expand all
28 #include "net/base/net_errors.h" 28 #include "net/base/net_errors.h"
29 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" 29 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
30 #include "net/base/static_cookie_policy.h" 30 #include "net/base/static_cookie_policy.h"
31 #include "net/http/http_request_headers.h" 31 #include "net/http/http_request_headers.h"
32 #include "net/http/http_util.h" 32 #include "net/http/http_util.h"
33 #include "net/url_request/url_request.h" 33 #include "net/url_request/url_request.h"
34 34
35 using base::CaseInsensitiveCompareASCII; 35 using base::CaseInsensitiveCompareASCII;
36 using base::DictionaryValue; 36 using base::DictionaryValue;
37 using base::ListValue; 37 using base::ListValue;
38 using base::StringValue;
39 using base::Value; 38 using base::Value;
40 39
41 namespace helpers = extension_web_request_api_helpers; 40 namespace helpers = extension_web_request_api_helpers;
42 namespace keys = extensions::declarative_webrequest_constants; 41 namespace keys = extensions::declarative_webrequest_constants;
43 42
44 namespace extensions { 43 namespace extensions {
45 44
46 namespace { 45 namespace {
47 // Error messages. 46 // Error messages.
48 const char kInvalidValue[] = "Condition '*' has an invalid value"; 47 const char kInvalidValue[] = "Condition '*' has an invalid value";
(...skipping 825 matching lines...) Expand 10 before | Expand all | Expand 10 after
874 bool WebRequestConditionAttributeStages::Equals( 873 bool WebRequestConditionAttributeStages::Equals(
875 const WebRequestConditionAttribute* other) const { 874 const WebRequestConditionAttribute* other) const {
876 if (!WebRequestConditionAttribute::Equals(other)) 875 if (!WebRequestConditionAttribute::Equals(other))
877 return false; 876 return false;
878 const WebRequestConditionAttributeStages* casted_other = 877 const WebRequestConditionAttributeStages* casted_other =
879 static_cast<const WebRequestConditionAttributeStages*>(other); 878 static_cast<const WebRequestConditionAttributeStages*>(other);
880 return allowed_stages_ == casted_other->allowed_stages_; 879 return allowed_stages_ == casted_other->allowed_stages_;
881 } 880 }
882 881
883 } // namespace extensions 882 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698