components/printing/renderer/print_web_view_helper.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index eaa294d97cf0375669c12b0e08526f95280fc0a2..f31074f26bb3c9c0416adcd3acfc192795c92126 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -591,7 +591,7 @@ void PrintWebViewHelper::PrintHeaderAndFooter(

web_view->setMainFrame(frame);

blink::WebFrameWidget::create(nullptr, web_view, frame);

- base::StringValue html(ResourceBundle::GetSharedInstance().GetLocalizedString(

+ base::Value html(ResourceBundle::GetSharedInstance().GetLocalizedString(

IDR_PRINT_PREVIEW_PAGE));

// Load page with script to avoid async operations.

ExecuteScript(frame, kPageLoadScriptFormat, html);