Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
index c5853e0cf13715721676ac88a2e0ffecde19add0..4ca4af2b5a7c0fc040222af80bfd88170f5d2194 100644
--- a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc
@@ -200,7 +200,7 @@ void NetInternalsTest::MessageHandler::GetTestServerURL(
std::string path;
ASSERT_TRUE(list_value->GetString(0, &path));
GURL url = net_internals_test_->embedded_test_server()->GetURL(path);
- std::unique_ptr<base::Value> url_value(new base::StringValue(url.spec()));
+ std::unique_ptr<base::Value> url_value(new base::Value(url.spec()));
RunJavascriptCallback(url_value.get());
}
@@ -261,7 +261,7 @@ void NetInternalsTest::MessageHandler::CreateIncognitoBrowser(
incognito_browser_ = net_internals_test_->CreateIncognitoBrowser();
// Tell the test harness that creation is complete.
- base::StringValue command_value("onIncognitoBrowserCreatedForTest");
+ base::Value command_value("onIncognitoBrowserCreatedForTest");
web_ui()->CallJavascriptFunctionUnsafe("g_browser.receive", command_value);
}
@@ -305,7 +305,7 @@ void NetInternalsTest::MessageHandler::GetNetLogFileContents(
ASSERT_GT(log_contents.length(), 0u);
std::unique_ptr<base::Value> log_contents_value(
- new base::StringValue(log_contents));
+ new base::Value(log_contents));
RunJavascriptCallback(log_contents_value.get());
}
« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698