Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3793)

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/session_commands.cc
diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc
index 528603c73fb0ce3fb2a6a0115141bd050851a9b3..1a39f53bc3a0574e07e8fb9e9ea019677c0ae3ee 100644
--- a/chrome/test/chromedriver/session_commands.cc
+++ b/chrome/test/chromedriver/session_commands.cc
@@ -279,8 +279,7 @@ Status ExecuteGetCurrentWindowHandle(Session* session,
if (status.IsError())
return status;
- value->reset(
- new base::StringValue(WebViewIdToWindowHandle(web_view->GetId())));
+ value->reset(new base::Value(WebViewIdToWindowHandle(web_view->GetId())));
return Status(kOk);
}
@@ -822,7 +821,7 @@ Status ExecuteUploadFile(Session* session,
if (status.IsError())
return Status(kUnknownError, "unable to unzip 'file'", status);
- value->reset(new base::StringValue(upload.value()));
+ value->reset(new base::Value(upload.value()));
return Status(kOk);
}
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/chromedriver/window_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698