chrome/test/chromedriver/commands.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/commands.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/commands.cc

diff --git a/chrome/test/chromedriver/commands.cc b/chrome/test/chromedriver/commands.cc

index 64a8aee0710f4df3a1fb73cddbd07145074fd457..3087083eef61372cf079b149043d1710bb3a9675 100644

--- a/chrome/test/chromedriver/commands.cc

+++ b/chrome/test/chromedriver/commands.cc

@@ -92,7 +92,7 @@ void OnGetSession(const base::WeakPtr<size_t>& session_remaining_count,

(*session_remaining_count)--;

std::unique_ptr<base::DictionaryValue> session(new base::DictionaryValue());

- session->Set("id", new base::StringValue(session_id));

+ session->Set("id", new base::Value(session_id));

session->Set("capabilities", value->DeepCopy());

session_list->Append(std::move(session));