Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/json/json_perftest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_parser.cc ('k') | base/json/json_writer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_perftest.cc
diff --git a/base/json/json_perftest.cc b/base/json/json_perftest.cc
index 345f226a2cf30be090dc5ebfe484da0d5b6077c1..15222468d783fe8c06ffb0760d9dd6c9606c8242 100644
--- a/base/json/json_perftest.cc
+++ b/base/json/json_perftest.cc
@@ -26,7 +26,7 @@ std::unique_ptr<DictionaryValue> GenerateDict() {
list->Set(0, MakeUnique<Value>(2.718));
list->Set(1, MakeUnique<Value>(false));
list->Set(2, MakeUnique<Value>(123));
- list->Set(3, MakeUnique<StringValue>("Bar"));
+ list->Set(3, MakeUnique<Value>("Bar"));
root->Set("List", std::move(list));
return root;
« no previous file with comments | « base/json/json_parser.cc ('k') | base/json/json_writer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698