Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
index c599ff744f5acdceb43cfd319965522a7beefd57..232e913c076dda66665a4b3781cd9058751287d8 100644
--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
@@ -304,7 +304,7 @@ class ExtensionMessageBubbleTest : public BrowserWithTestWindowTest {
false); // is_incognito_enabled.
extension_prefs_value_map->SetExtensionPref(id, proxy_config::prefs::kProxy,
kExtensionPrefsScopeRegular,
- new base::StringValue(id));
+ new base::Value(id));
if (ExtensionRegistry::Get(profile())->enabled_extensions().GetByID(id))
return testing::AssertionSuccess();
@@ -915,9 +915,8 @@ void SetInstallTime(const std::string& extension_id,
const base::Time& time,
ExtensionPrefs* prefs) {
std::string time_str = base::Int64ToString(time.ToInternalValue());
- prefs->UpdateExtensionPref(extension_id,
- "install_time",
- new base::StringValue(time_str));
+ prefs->UpdateExtensionPref(extension_id, "install_time",
+ new base::Value(time_str));
}
// The feature this is meant to test is only implemented on Windows and Mac.

Powered by Google App Engine
This is Rietveld 408576698