Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3470)

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
index dd8d078d7892d8d5eb4838d738fec4e5e7f584a2..30f8aa2e9e2b0febb5d6ddf398c595502815280e 100644
--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
@@ -241,7 +241,7 @@ void ClearBrowsingDataHandler::OnClearingTaskFinished(
UMA_HISTOGRAM_BOOLEAN(
"History.ClearBrowsingData.ShownHistoryNoticeAfterClearing", show_notice);
- ResolveJavascriptCallback(base::StringValue(webui_callback_id),
+ ResolveJavascriptCallback(base::Value(webui_callback_id),
base::Value(show_notice));
task_observer_.reset();
}
@@ -272,7 +272,7 @@ void ClearBrowsingDataHandler::OnStateChanged(syncer::SyncService* sync) {
void ClearBrowsingDataHandler::UpdateSyncState() {
CallJavascriptFunction(
- "cr.webUIListenerCallback", base::StringValue("update-footer"),
+ "cr.webUIListenerCallback", base::Value("update-footer"),
base::Value(sync_service_ && sync_service_->IsSyncActive()),
base::Value(show_history_footer_));
}
@@ -326,9 +326,9 @@ void ClearBrowsingDataHandler::AddCounter(
void ClearBrowsingDataHandler::UpdateCounterText(
std::unique_ptr<browsing_data::BrowsingDataCounter::Result> result) {
CallJavascriptFunction(
- "cr.webUIListenerCallback", base::StringValue("update-counter-text"),
- base::StringValue(result->source()->GetPrefName()),
- base::StringValue(GetChromeCounterTextFromResult(result.get())));
+ "cr.webUIListenerCallback", base::Value("update-counter-text"),
+ base::Value(result->source()->GetPrefName()),
+ base::Value(GetChromeCounterTextFromResult(result.get())));
}
} // namespace settings

Powered by Google App Engine
This is Rietveld 408576698