Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: net/http/transport_security_state.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/common/values_struct_traits.cc ('k') | net/log/file_net_log_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/transport_security_state.cc
diff --git a/net/http/transport_security_state.cc b/net/http/transport_security_state.cc
index 5f82c2897b51ec403963e9da6674c389f38aff73..fa4f7876780fca1c86a0b32c1278f75d615f0716 100644
--- a/net/http/transport_security_state.cc
+++ b/net/http/transport_security_state.cc
@@ -91,7 +91,7 @@ std::unique_ptr<base::ListValue> GetPEMEncodedChainAsList(
std::vector<std::string> pem_encoded_chain;
cert_chain->GetPEMEncodedChain(&pem_encoded_chain);
for (const std::string& cert : pem_encoded_chain)
- result->Append(base::MakeUnique<base::StringValue>(cert));
+ result->Append(base::MakeUnique<base::Value>(cert));
return result;
}
@@ -157,7 +157,7 @@ bool GetHPKPReport(const HostPortPair& host_port_pair,
known_pin += "\"" + base64_value + "\"";
known_pin_list->Append(
- std::unique_ptr<base::Value>(new base::StringValue(known_pin)));
+ std::unique_ptr<base::Value>(new base::Value(known_pin)));
}
report.Set("known-pins", std::move(known_pin_list));
« no previous file with comments | « mojo/common/values_struct_traits.cc ('k') | net/log/file_net_log_observer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698