chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc

diff --git a/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc b/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc

index 2fc8de3a22d52b1eab75ef8d0046372e4cb5ea7f..4d1793407c5173e9ef2cc3fe54078a70cedeb573 100644

--- a/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc

+++ b/chrome/browser/ui/webui/local_state/local_state_ui_unittest.cc

@@ -19,7 +19,7 @@ TEST(LocalStateUiTest, FilterPrefs) {

base::DictionaryValue prefs;

for (const std::string& key : all_pref_keys) {

- prefs.Set(key, new base::StringValue(key + "_value"));

+ prefs.Set(key, new base::Value(key + "_value"));

}

internal::FilterPrefs(prefixes, &prefs);