content/shell/browser/layout_test/layout_test_devtools_frontend.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_devtools_frontend.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/layout_test/layout_test_devtools_frontend.cc

diff --git a/content/shell/browser/layout_test/layout_test_devtools_frontend.cc b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc

index 917a876455bfb260dea28c70cc07cda98256ee5c..ac62b4a8c4bfd8d4f72fb7a325cdca5a312a20c6 100644

--- a/content/shell/browser/layout_test/layout_test_devtools_frontend.cc

+++ b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc

@@ -102,7 +102,7 @@ void LayoutTestDevToolsFrontend::EvaluateInFrontend(

}

std::string encoded_script;

- base::JSONWriter::Write(base::StringValue(script), &encoded_script);

+ base::JSONWriter::Write(base::Value(script), &encoded_script);

std::string source =

base::StringPrintf("DevToolsAPI.evaluateForTestInFrontend(%d, %s);",

call_id,