chrome/browser/extensions/activity_log/activity_actions.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/activity_log/activity_actions.cc

diff --git a/chrome/browser/extensions/activity_log/activity_actions.cc b/chrome/browser/extensions/activity_log/activity_actions.cc

index adc78e0fc09ac7b72c21a77c2557cb268a6ef925..ec44aec33f384de5c9526db44fc770fe442eda9b 100644

--- a/chrome/browser/extensions/activity_log/activity_actions.cc

+++ b/chrome/browser/extensions/activity_log/activity_actions.cc

@@ -287,7 +287,7 @@ std::string Action::PrintForDebug() const {

result += " PAGE_URL=" + page_url_.spec();

}

if (!page_title_.empty()) {

- base::StringValue title(page_title_);

+ base::Value title(page_title_);

result += " PAGE_TITLE=" + Serialize(&title);

}

if (arg_url_.is_valid()) {