Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/json_schema_compiler/test/choices_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/choices_unittest.cc
diff --git a/tools/json_schema_compiler/test/choices_unittest.cc b/tools/json_schema_compiler/test/choices_unittest.cc
index 584641c7f20567169834666ba85b2b9b7edd5015..35ec22984cf4e86e2faaa90845ca6d6c9c057a27 100644
--- a/tools/json_schema_compiler/test/choices_unittest.cc
+++ b/tools/json_schema_compiler/test/choices_unittest.cc
@@ -46,8 +46,8 @@ TEST(JsonSchemaCompilerChoicesTest, TakesIntegersParamsCreate) {
TEST(JsonSchemaCompilerChoicesTest, ObjectWithChoicesParamsCreate) {
{
std::unique_ptr<ObjectWithChoices::Params> params(
- ObjectWithChoices::Params::Create(*List(
- Dictionary("strings", new base::StringValue("asdf")).release())));
+ ObjectWithChoices::Params::Create(
+ *List(Dictionary("strings", new base::Value("asdf")).release())));
ASSERT_TRUE(params);
EXPECT_FALSE(params->string_info.strings.as_strings);
EXPECT_EQ("asdf", *params->string_info.strings.as_string);
@@ -56,8 +56,8 @@ TEST(JsonSchemaCompilerChoicesTest, ObjectWithChoicesParamsCreate) {
{
std::unique_ptr<ObjectWithChoices::Params> params(
ObjectWithChoices::Params::Create(
- *List(Dictionary("strings", new base::StringValue("asdf"),
- "integers", new base::Value(6))
+ *List(Dictionary("strings", new base::Value("asdf"), "integers",
+ new base::Value(6))
.release())));
ASSERT_TRUE(params);
EXPECT_FALSE(params->string_info.strings.as_strings);
@@ -85,10 +85,8 @@ TEST(JsonSchemaCompilerChoicesTest, ObjectWithChoicesParamsCreateFail) {
{
std::unique_ptr<base::DictionaryValue> object_param(
new base::DictionaryValue());
- object_param->SetWithoutPathExpansion("strings",
- new base::StringValue("asdf"));
- object_param->SetWithoutPathExpansion("integers",
- new base::StringValue("asdf"));
+ object_param->SetWithoutPathExpansion("strings", new base::Value("asdf"));
+ object_param->SetWithoutPathExpansion("integers", new base::Value("asdf"));
std::unique_ptr<base::ListValue> params_value(new base::ListValue());
params_value->Append(std::move(object_param));
std::unique_ptr<ObjectWithChoices::Params> params(
« no previous file with comments | « tools/json_schema_compiler/test/any_unittest.cc ('k') | tools/json_schema_compiler/test/crossref_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698