Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Unified Diff: base/test/values_test_util.h

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_writer_unittest.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/test/values_test_util.h
diff --git a/base/test/values_test_util.h b/base/test/values_test_util.h
index 04af92e5ac9938485e18fa7b26201bb07af1291f..e545660fbed318069b0a8dc834b2e54b33b6e37d 100644
--- a/base/test/values_test_util.h
+++ b/base/test/values_test_util.h
@@ -14,7 +14,6 @@ namespace base {
class DictionaryValue;
class ListValue;
class Value;
-using StringValue = Value;
// All the functions below expect that the value for the given key in
// the given dictionary equals the given expected value.
@@ -40,8 +39,7 @@ void ExpectDictStringValue(const std::string& expected_value,
const std::string& key);
// Takes ownership of |actual|.
-void ExpectStringValue(const std::string& expected_str,
- StringValue* actual);
+void ExpectStringValue(const std::string& expected_str, Value* actual);
namespace test {
« no previous file with comments | « base/json/json_writer_unittest.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698