Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5222)

Unified Diff: chromeos/dbus/shill_manager_client_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_ipconfig_client_unittest.cc ('k') | chromeos/dbus/shill_profile_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_manager_client_unittest.cc
diff --git a/chromeos/dbus/shill_manager_client_unittest.cc b/chromeos/dbus/shill_manager_client_unittest.cc
index f46cad6be11952b84e7de553c2dbd0f580eb418b..67e2c7cc937e317c169a56bae8b1aaca396c121f 100644
--- a/chromeos/dbus/shill_manager_client_unittest.cc
+++ b/chromeos/dbus/shill_manager_client_unittest.cc
@@ -184,8 +184,7 @@ TEST_F(ShillManagerClientTest, GetNetworksForGeolocation) {
base::ListValue* type_entry_value = new base::ListValue;
auto property_dict_value = base::MakeUnique<base::DictionaryValue>();
property_dict_value->SetWithoutPathExpansion(
- shill::kGeoMacAddressProperty,
- new base::StringValue("01:23:45:67:89:AB"));
+ shill::kGeoMacAddressProperty, new base::Value("01:23:45:67:89:AB"));
type_entry_value->Append(std::move(property_dict_value));
type_dict_value.SetWithoutPathExpansion("wifi", type_entry_value);
@@ -205,7 +204,7 @@ TEST_F(ShillManagerClientTest, SetProperty) {
// Create response.
std::unique_ptr<dbus::Response> response(dbus::Response::CreateEmpty());
// Set expectations.
- base::StringValue value("portal list");
+ base::Value value("portal list");
PrepareForMethodCall(shill::kSetPropertyFunction,
base::Bind(ExpectStringAndValueArguments,
shill::kCheckPortalListProperty,
« no previous file with comments | « chromeos/dbus/shill_ipconfig_client_unittest.cc ('k') | chromeos/dbus/shill_profile_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698