Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/ui/webui/options/chromeos/accounts_options_browsertest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 26 matching lines...) Expand all
37 37
38 } // namespace 38 } // namespace
39 39
40 class AccountsOptionsTest : public LoginManagerTest { 40 class AccountsOptionsTest : public LoginManagerTest {
41 public: 41 public:
42 AccountsOptionsTest() 42 AccountsOptionsTest()
43 : LoginManagerTest(false), 43 : LoginManagerTest(false),
44 stub_settings_provider_(base::MakeUnique<StubCrosSettingsProvider>()), 44 stub_settings_provider_(base::MakeUnique<StubCrosSettingsProvider>()),
45 stub_settings_provider_ptr_(static_cast<StubCrosSettingsProvider*>( 45 stub_settings_provider_ptr_(static_cast<StubCrosSettingsProvider*>(
46 stub_settings_provider_.get())) { 46 stub_settings_provider_.get())) {
47 stub_settings_provider_->Set(kDeviceOwner, 47 stub_settings_provider_->Set(kDeviceOwner, base::Value(kTestUsers[0]));
48 base::StringValue(kTestUsers[0]));
49 for (size_t i = 0; i < arraysize(kTestUsers); ++i) { 48 for (size_t i = 0; i < arraysize(kTestUsers); ++i) {
50 test_users_.push_back(AccountId::FromUserEmail(kTestUsers[i])); 49 test_users_.push_back(AccountId::FromUserEmail(kTestUsers[i]));
51 } 50 }
52 } 51 }
53 52
54 ~AccountsOptionsTest() override {} 53 ~AccountsOptionsTest() override {}
55 54
56 void SetUpOnMainThread() override { 55 void SetUpOnMainThread() override {
57 LoginManagerTest::SetUpOnMainThread(); 56 LoginManagerTest::SetUpOnMainThread();
58 CrosSettings* settings = CrosSettings::Get(); 57 CrosSettings* settings = CrosSettings::Get();
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 AddUser(test_users_[1].GetUserEmail()); 157 AddUser(test_users_[1].GetUserEmail());
159 158
160 user_manager::UserManager* manager = user_manager::UserManager::Get(); 159 user_manager::UserManager* manager = user_manager::UserManager::Get();
161 ASSERT_EQ(2u, manager->GetLoggedInUsers().size()); 160 ASSERT_EQ(2u, manager->GetLoggedInUsers().size());
162 161
163 CheckAccountsUI(manager->FindUser(test_users_[0]), true /* is_owner */); 162 CheckAccountsUI(manager->FindUser(test_users_[0]), true /* is_owner */);
164 CheckAccountsUI(manager->FindUser(test_users_[1]), false /* is_owner */); 163 CheckAccountsUI(manager->FindUser(test_users_[1]), false /* is_owner */);
165 } 164 }
166 165
167 } // namespace chromeos 166 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698