Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: components/prefs/pref_change_registrar_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/prefs/json_pref_store_unittest.cc ('k') | components/prefs/pref_registry_simple.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/prefs/pref_change_registrar_unittest.cc
diff --git a/components/prefs/pref_change_registrar_unittest.cc b/components/prefs/pref_change_registrar_unittest.cc
index 68b62cd2fedcbef0bf02061e31e1b94ab359ed9e..cecaca85ed90bd38f8bf23288a1b6da32b8f6b83 100644
--- a/components/prefs/pref_change_registrar_unittest.cc
+++ b/components/prefs/pref_change_registrar_unittest.cc
@@ -157,8 +157,7 @@ TEST_F(ObserveSetOfPreferencesTest, IsObserved) {
TEST_F(ObserveSetOfPreferencesTest, IsManaged) {
std::unique_ptr<PrefChangeRegistrar> pref_set(CreatePrefChangeRegistrar());
EXPECT_FALSE(pref_set->IsManaged());
- pref_service_->SetManagedPref(kHomePage,
- new StringValue("http://crbug.com"));
+ pref_service_->SetManagedPref(kHomePage, new Value("http://crbug.com"));
EXPECT_TRUE(pref_set->IsManaged());
pref_service_->SetManagedPref(kHomePageIsNewTabPage, new Value(true));
EXPECT_TRUE(pref_set->IsManaged());
@@ -181,7 +180,7 @@ TEST_F(ObserveSetOfPreferencesTest, Observe) {
pref_set.Add(kHomePageIsNewTabPage, callback);
EXPECT_CALL(*this, OnPreferenceChanged(kHomePage));
- pref_service_->SetUserPref(kHomePage, new StringValue("http://crbug.com"));
+ pref_service_->SetUserPref(kHomePage, new Value("http://crbug.com"));
Mock::VerifyAndClearExpectations(this);
EXPECT_CALL(*this, OnPreferenceChanged(kHomePageIsNewTabPage));
@@ -189,7 +188,7 @@ TEST_F(ObserveSetOfPreferencesTest, Observe) {
Mock::VerifyAndClearExpectations(this);
EXPECT_CALL(*this, OnPreferenceChanged(_)).Times(0);
- pref_service_->SetUserPref(kApplicationLocale, new StringValue("en_US.utf8"));
+ pref_service_->SetUserPref(kApplicationLocale, new Value("en_US.utf8"));
Mock::VerifyAndClearExpectations(this);
}
« no previous file with comments | « components/prefs/json_pref_store_unittest.cc ('k') | components/prefs/pref_registry_simple.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698