Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chromeos/dbus/shill_ipconfig_client_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_client_unittest_base.cc ('k') | chromeos/dbus/shill_manager_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_ipconfig_client_unittest.cc
diff --git a/chromeos/dbus/shill_ipconfig_client_unittest.cc b/chromeos/dbus/shill_ipconfig_client_unittest.cc
index 8f884d7a5c9084856754ad254cbe048036ce189d..dd79e2ce43c35bac347e3d442651986b14bc7d5e 100644
--- a/chromeos/dbus/shill_ipconfig_client_unittest.cc
+++ b/chromeos/dbus/shill_ipconfig_client_unittest.cc
@@ -106,7 +106,7 @@ TEST_F(ShillIPConfigClientTest, GetProperties) {
// Create the expected value.
base::DictionaryValue value;
value.SetWithoutPathExpansion(shill::kAddressProperty,
- new base::StringValue(kAddress));
+ new base::Value(kAddress));
value.SetWithoutPathExpansion(shill::kMtuProperty, new base::Value(kMtu));
// Set expectations.
@@ -127,7 +127,7 @@ TEST_F(ShillIPConfigClientTest, SetProperty) {
std::unique_ptr<dbus::Response> response(dbus::Response::CreateEmpty());
// Set expectations.
- base::StringValue value(kAddress);
+ base::Value value(kAddress);
PrepareForMethodCall(shill::kSetPropertyFunction,
base::Bind(&ExpectStringAndValueArguments,
shill::kAddressProperty,
« no previous file with comments | « chromeos/dbus/shill_client_unittest_base.cc ('k') | chromeos/dbus/shill_manager_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698