Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chromeos/dbus/gsm_sms_client_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/dbus/shill_client_unittest_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/gsm_sms_client_unittest.cc
diff --git a/chromeos/dbus/gsm_sms_client_unittest.cc b/chromeos/dbus/gsm_sms_client_unittest.cc
index 5cadf58e8126588a12bad28a27b2e490ea674515..fb52c37479eeb03281efe41f272ecc4248076f76 100644
--- a/chromeos/dbus/gsm_sms_client_unittest.cc
+++ b/chromeos/dbus/gsm_sms_client_unittest.cc
@@ -256,10 +256,10 @@ TEST_F(GsmSMSClientTest, Get) {
response_ = response.get();
// Create expected result.
base::DictionaryValue expected_result;
- expected_result.SetWithoutPathExpansion(
- kNumberKey, new base::StringValue(kExampleNumber));
+ expected_result.SetWithoutPathExpansion(kNumberKey,
+ new base::Value(kExampleNumber));
expected_result.SetWithoutPathExpansion(kTextKey,
- new base::StringValue(kExampleText));
+ new base::Value(kExampleText));
expected_result_ = &expected_result;
// Call Get.
client_->Get(kServiceName, dbus::ObjectPath(kObjectPath), kIndex,
@@ -298,9 +298,8 @@ TEST_F(GsmSMSClientTest, List) {
// Create expected result.
base::ListValue expected_result;
auto sms = base::MakeUnique<base::DictionaryValue>();
- sms->SetWithoutPathExpansion(kNumberKey,
- new base::StringValue(kExampleNumber));
- sms->SetWithoutPathExpansion(kTextKey, new base::StringValue(kExampleText));
+ sms->SetWithoutPathExpansion(kNumberKey, new base::Value(kExampleNumber));
+ sms->SetWithoutPathExpansion(kTextKey, new base::Value(kExampleText));
expected_result.Append(std::move(sms));
expected_result_ = &expected_result;
// Call List.
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/dbus/shill_client_unittest_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698