chrome/browser/download/download_dir_policy_handler.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_dir_policy_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_dir_policy_handler.cc

diff --git a/chrome/browser/download/download_dir_policy_handler.cc b/chrome/browser/download/download_dir_policy_handler.cc

index b64c616f769c2198007d3762f329edc1cc30023c..cf48ade60d46203360faa546ab6d78c9666cfd2b 100644

--- a/chrome/browser/download/download_dir_policy_handler.cc

+++ b/chrome/browser/download/download_dir_policy_handler.cc

@@ -105,7 +105,7 @@ void DownloadDirPolicyHandler::ApplyPolicySettingsWithParameters(

if (expanded_value.empty())

expanded_value = DownloadPrefs::GetDefaultDownloadDirectory().value();

prefs->SetValue(prefs::kDownloadDefaultDirectory,

- base::MakeUnique<base::StringValue>(expanded_value));

+ base::MakeUnique<base::Value>(expanded_value));

// If the policy is mandatory, prompt for download should be disabled.

// Otherwise, it would enable a user to bypass the mandatory policy.