Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: components/prefs/command_line_pref_store.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/prefs/command_line_pref_store.cc
diff --git a/components/prefs/command_line_pref_store.cc b/components/prefs/command_line_pref_store.cc
index 49278c19f2a0168a747b5d84fc69e59d56c3b7a2..ddaac31ebfbc9e6e69351712f9d24c5ffd871c9e 100644
--- a/components/prefs/command_line_pref_store.cc
+++ b/components/prefs/command_line_pref_store.cc
@@ -22,9 +22,8 @@ void CommandLinePrefStore::ApplyStringSwitches(
for (size_t i = 0; i < size; ++i) {
if (command_line_->HasSwitch(string_switch[i].switch_name)) {
SetValue(string_switch[i].preference_path,
- base::MakeUnique<base::StringValue>(
- command_line_->GetSwitchValueASCII(
- string_switch[i].switch_name)),
+ base::MakeUnique<base::Value>(command_line_->GetSwitchValueASCII(
+ string_switch[i].switch_name)),
WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
}
}
@@ -35,12 +34,11 @@ void CommandLinePrefStore::ApplyPathSwitches(
size_t size) {
for (size_t i = 0; i < size; ++i) {
if (command_line_->HasSwitch(path_switch[i].switch_name)) {
- SetValue(
- path_switch[i].preference_path,
- base::MakeUnique<base::StringValue>(
- command_line_->GetSwitchValuePath(path_switch[i].switch_name)
- .value()),
- WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
+ SetValue(path_switch[i].preference_path,
+ base::MakeUnique<base::Value>(
+ command_line_->GetSwitchValuePath(path_switch[i].switch_name)
+ .value()),
+ WriteablePrefStore::DEFAULT_PREF_WRITE_FLAGS);
}
}
}
« no previous file with comments | « components/policy/tools/generate_policy_source_test.py ('k') | components/prefs/default_pref_store_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698