Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/values_util_unittest.cc ('k') | device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc
diff --git a/device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc b/device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc
index d9d8d028b43a216ca0834112e6aa63f62ad68235..ba66a4b29aeae653384175591e733ef460e4b867 100644
--- a/device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc
+++ b/device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc
@@ -48,7 +48,7 @@ std::unique_ptr<Sequence> MakeSequence(
TEST(BluetoothServiceAttributeBlueZTest, BasicValue) {
BluetoothServiceAttributeValueBlueZ value1(
- Type::UUID, 16, base::MakeUnique<base::StringValue>(kServiceUuid));
+ Type::UUID, 16, base::MakeUnique<base::Value>(kServiceUuid));
BluetoothServiceAttributeValueBlueZ value2 = value1;
CheckUuidValue(value2, kServiceUuid);
@@ -56,7 +56,7 @@ TEST(BluetoothServiceAttributeBlueZTest, BasicValue) {
TEST(BluetoothServiceAttributeBlueZTest, Sequence) {
BluetoothServiceAttributeValueBlueZ value1(
- Type::UUID, 16, base::MakeUnique<base::StringValue>(kServiceUuid));
+ Type::UUID, 16, base::MakeUnique<base::Value>(kServiceUuid));
BluetoothServiceAttributeValueBlueZ value2(
Type::INT, 4, base::MakeUnique<base::Value>(0x1337));
BluetoothServiceAttributeValueBlueZ value3(
@@ -80,7 +80,7 @@ TEST(BluetoothServiceAttributeBlueZTest, Sequence) {
TEST(BluetoothServiceAttributeBlueZTest, NestedValue) {
BluetoothServiceAttributeValueBlueZ value1(
- Type::UUID, 16, base::MakeUnique<base::StringValue>(kServiceUuid));
+ Type::UUID, 16, base::MakeUnique<base::Value>(kServiceUuid));
BluetoothServiceAttributeValueBlueZ value2(
Type::INT, 4, base::MakeUnique<base::Value>(0x1337));
BluetoothServiceAttributeValueBlueZ value3(MakeSequence({value1, value2}));
@@ -124,7 +124,7 @@ TEST(BluetoothServiceAttributeBlueZTest, NestedValue) {
TEST(BluetoothServiceAttributeBlueZTest, CopyAssignment) {
BluetoothServiceAttributeValueBlueZ value1(
- Type::UUID, 16, base::MakeUnique<base::StringValue>(kServiceUuid));
+ Type::UUID, 16, base::MakeUnique<base::Value>(kServiceUuid));
BluetoothServiceAttributeValueBlueZ value2(
Type::INT, 4, base::MakeUnique<base::Value>(0x1337));
BluetoothServiceAttributeValueBlueZ value3(
« no previous file with comments | « dbus/values_util_unittest.cc ('k') | device/bluetooth/bluez/bluetooth_service_record_bluez_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698