chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_get_auth_token_function.cc ('k') | chrome/browser/extensions/api/instance_id/instance_id_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc

diff --git a/chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc b/chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc

index 2f000686f006438124bff09b13de542f197ffa3f..882c858b85aac3bfb9825d7da044611ed3323070 100644

--- a/chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc

+++ b/chrome/browser/extensions/api/identity/identity_launch_web_auth_flow_function.cc

@@ -91,7 +91,7 @@ void IdentityLaunchWebAuthFlowFunction::OnAuthFlowFailure(

void IdentityLaunchWebAuthFlowFunction::OnAuthFlowURLChange(

const GURL& redirect_url) {

if (redirect_url.GetWithEmptyPath() == final_url_prefix_) {

- SetResult(base::MakeUnique<base::StringValue>(redirect_url.spec()));

+ SetResult(base::MakeUnique<base::Value>(redirect_url.spec()));

SendResponse(true);

if (auth_flow_)

auth_flow_.release()->DetachDelegateAndDelete();