Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: dbus/values_util.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/test_runner/tracked_dictionary.cc ('k') | dbus/values_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/values_util.cc
diff --git a/dbus/values_util.cc b/dbus/values_util.cc
index 58b2b9ed7f7b9fe00674019b1c264cfb870631cc..1e035c9cfe9e5ee416e84e0732c90ec2c0369e26 100644
--- a/dbus/values_util.cc
+++ b/dbus/values_util.cc
@@ -159,13 +159,13 @@ std::unique_ptr<base::Value> PopDataAsValue(MessageReader* reader) {
case Message::STRING: {
std::string value;
if (reader->PopString(&value))
- result = base::MakeUnique<base::StringValue>(value);
+ result = base::MakeUnique<base::Value>(value);
break;
}
case Message::OBJECT_PATH: {
ObjectPath value;
if (reader->PopObjectPath(&value))
- result = base::MakeUnique<base::StringValue>(value.value());
+ result = base::MakeUnique<base::Value>(value.value());
break;
}
case Message::UNIX_FD: {
« no previous file with comments | « content/shell/test_runner/tracked_dictionary.cc ('k') | dbus/values_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698