components/dom_distiller/ios/distiller_page_ios.mm - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/ios/distiller_page_ios.mm

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/dom_distiller/ios/distiller_page_ios.mm

diff --git a/components/dom_distiller/ios/distiller_page_ios.mm b/components/dom_distiller/ios/distiller_page_ios.mm

index 4773be550d69ed4dd1a3d75941a6588e815f6aba..04bfd9008bd156e9a5da91b44d6b29d20567d9a3 100644

--- a/components/dom_distiller/ios/distiller_page_ios.mm

+++ b/components/dom_distiller/ios/distiller_page_ios.mm

@@ -50,7 +50,7 @@ std::unique_ptr<base::Value> ValueResultFromScriptResult(id wk_result,

CFTypeID result_type = CFGetTypeID(wk_result);

if (result_type == CFStringGetTypeID()) {

- result.reset(new base::StringValue(base::SysNSStringToUTF16(wk_result)));

+ result.reset(new base::Value(base::SysNSStringToUTF16(wk_result)));

DCHECK(result->IsType(base::Value::Type::STRING));

} else if (result_type == CFNumberGetTypeID()) {

// Different implementation is here.