Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1530)

Unified Diff: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/webui/crashes_ui.cc ('k') | ios/web/web_state/ui/web_view_js_utils.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
diff --git a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
index 8ee1b6145de21fa2c519d9cd77c3e9636e4a7ce6..4a136416c31d2eb21477d4f99ac8c7da66751e4a 100644
--- a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
+++ b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
@@ -125,13 +125,12 @@ void SyncInternalsMessageHandler::HandleRequestListOfTypes(
ModelTypeSet protocol_types = syncer::ProtocolTypes();
for (ModelTypeSet::Iterator it = protocol_types.First(); it.Good();
it.Inc()) {
- type_list->Append(new base::StringValue(ModelTypeToString(it.Get())));
+ type_list->Append(new base::Value(ModelTypeToString(it.Get())));
}
event_details.Set(syncer::sync_ui_util::kTypes, type_list.release());
web_ui()->CallJavascriptFunction(
syncer::sync_ui_util::kDispatchEvent,
- base::StringValue(syncer::sync_ui_util::kOnReceivedListOfTypes),
- event_details);
+ base::Value(syncer::sync_ui_util::kOnReceivedListOfTypes), event_details);
}
void SyncInternalsMessageHandler::HandleGetAllNodes(
@@ -167,7 +166,7 @@ void SyncInternalsMessageHandler::OnProtocolEvent(
syncer::ProtocolEvent::ToValue(event));
web_ui()->CallJavascriptFunction(
syncer::sync_ui_util::kDispatchEvent,
- base::StringValue(syncer::sync_ui_util::kOnProtocolEvent), *value);
+ base::Value(syncer::sync_ui_util::kOnProtocolEvent), *value);
}
void SyncInternalsMessageHandler::OnCommitCountersUpdated(
@@ -198,7 +197,7 @@ void SyncInternalsMessageHandler::EmitCounterUpdate(
details->Set(syncer::sync_ui_util::kCounters, value.release());
web_ui()->CallJavascriptFunction(
syncer::sync_ui_util::kDispatchEvent,
- base::StringValue(syncer::sync_ui_util::kOnCountersUpdated), *details);
+ base::Value(syncer::sync_ui_util::kOnCountersUpdated), *details);
}
void SyncInternalsMessageHandler::HandleJsEvent(const std::string& name,
@@ -206,7 +205,7 @@ void SyncInternalsMessageHandler::HandleJsEvent(const std::string& name,
DVLOG(1) << "Handling event: " << name << " with details "
<< details.ToString();
web_ui()->CallJavascriptFunction(syncer::sync_ui_util::kDispatchEvent,
- base::StringValue(name), details.Get());
+ base::Value(name), details.Get());
}
void SyncInternalsMessageHandler::SendAboutInfo() {
@@ -220,7 +219,7 @@ void SyncInternalsMessageHandler::SendAboutInfo() {
sync_service, signin_manager, GetChannel());
web_ui()->CallJavascriptFunction(
syncer::sync_ui_util::kDispatchEvent,
- base::StringValue(syncer::sync_ui_util::kOnAboutInfoUpdated), *value);
+ base::Value(syncer::sync_ui_util::kOnAboutInfoUpdated), *value);
}
// Gets the SyncService of the underlying original profile. May return null.
« no previous file with comments | « ios/chrome/browser/ui/webui/crashes_ui.cc ('k') | ios/web/web_state/ui/web_view_js_utils.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698