Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Side by Side Diff: components/autofill/content/renderer/renderer_save_password_progress_logger.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/content/renderer/renderer_save_password_progress_l ogger.h" 5 #include "components/autofill/content/renderer/renderer_save_password_progress_l ogger.h"
6 6
7 #include "base/strings/string16.h" 7 #include "base/strings/string16.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "third_party/WebKit/public/web/WebFormControlElement.h" 9 #include "third_party/WebKit/public/web/WebFormControlElement.h"
10 10
11 namespace autofill { 11 namespace autofill {
12 12
13 RendererSavePasswordProgressLogger::RendererSavePasswordProgressLogger( 13 RendererSavePasswordProgressLogger::RendererSavePasswordProgressLogger(
14 mojom::PasswordManagerDriver* password_manager_driver) 14 mojom::PasswordManagerDriver* password_manager_driver)
15 : password_manager_driver_(password_manager_driver) { 15 : password_manager_driver_(password_manager_driver) {
16 DCHECK(password_manager_driver); 16 DCHECK(password_manager_driver);
17 } 17 }
18 18
19 RendererSavePasswordProgressLogger::~RendererSavePasswordProgressLogger() {} 19 RendererSavePasswordProgressLogger::~RendererSavePasswordProgressLogger() {}
20 20
21 void RendererSavePasswordProgressLogger::SendLog(const std::string& log) { 21 void RendererSavePasswordProgressLogger::SendLog(const std::string& log) {
22 password_manager_driver_->RecordSavePasswordProgress(log); 22 password_manager_driver_->RecordSavePasswordProgress(log);
23 } 23 }
24 24
25 void RendererSavePasswordProgressLogger::LogElementName( 25 void RendererSavePasswordProgressLogger::LogElementName(
26 StringID label, 26 StringID label,
27 const blink::WebFormControlElement& element) { 27 const blink::WebFormControlElement& element) {
28 LogValue(label, base::StringValue( 28 LogValue(label,
29 ScrubElementID((element.nameForAutofill().utf16())))); 29 base::Value(ScrubElementID((element.nameForAutofill().utf16()))));
30 } 30 }
31 31
32 } // namespace autofill 32 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698