chrome/browser/chromeos/options/network_property_ui_data_unittest.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/wake_on_wifi_manager.cc ('k') | chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

diff --git a/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc b/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

index 5c6f6e564afdc66bd363207c5e2b60bbb698609d..adb1885241584f8549534ef572942dd68293d82c 100644

--- a/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

+++ b/chrome/browser/chromeos/options/network_property_ui_data_unittest.cc

@@ -41,10 +41,10 @@ TEST_F(NetworkPropertyUIDataTest, PropertyInit) {

TEST_F(NetworkPropertyUIDataTest, ParseOncProperty) {

base::DictionaryValue onc;

- base::StringValue val_a("a");

- base::StringValue val_b("b");

- base::StringValue val_a_a("a_a");

- base::StringValue val_a_b("a_b");

+ base::Value val_a("a");

+ base::Value val_b("b");

+ base::Value val_a_a("a_a");

+ base::Value val_a_b("a_b");

onc.Set("a", val_a.DeepCopy());

onc.Set("b", val_b.DeepCopy());