content/browser/devtools/protocol_string.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol_string.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/protocol_string.cc

diff --git a/content/browser/devtools/protocol_string.cc b/content/browser/devtools/protocol_string.cc

index 452949a289ae1c28d5a6b1faacb63eb40c224a56..994e478b3baa947ef5e45cc24c9b1fc0234b33e6 100644

--- a/content/browser/devtools/protocol_string.cc

+++ b/content/browser/devtools/protocol_string.cc

@@ -93,7 +93,7 @@ std::unique_ptr<base::Value> toBaseValue(

if (value->type() == protocol::Value::TypeString) {

std::string inner;

value->asString(&inner);

- return base::WrapUnique(new base::StringValue(inner));

+ return base::WrapUnique(new base::Value(inner));

}

if (value->type() == protocol::Value::TypeArray) {

protocol::ListValue* list = protocol::ListValue::cast(value);