Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: content/child/v8_value_converter_impl.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/child/v8_value_converter_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/v8_value_converter_impl.cc
diff --git a/content/child/v8_value_converter_impl.cc b/content/child/v8_value_converter_impl.cc
index c57bd15c81b6e4366129180421f5367361eeef57..b445760fcaeccd5a51e9843f1401237214a8c016 100644
--- a/content/child/v8_value_converter_impl.cc
+++ b/content/child/v8_value_converter_impl.cc
@@ -386,8 +386,7 @@ std::unique_ptr<base::Value> V8ValueConverterImpl::FromV8ValueImpl(
if (val->IsString()) {
v8::String::Utf8Value utf8(val);
- return base::MakeUnique<base::StringValue>(
- std::string(*utf8, utf8.length()));
+ return base::MakeUnique<base::Value>(std::string(*utf8, utf8.length()));
}
if (val->IsUndefined()) {
@@ -413,7 +412,7 @@ std::unique_ptr<base::Value> V8ValueConverterImpl::FromV8ValueImpl(
if (!reg_exp_allowed_)
// JSON.stringify converts to an object.
return FromV8Object(val.As<v8::Object>(), state, isolate);
- return base::MakeUnique<base::StringValue>(*v8::String::Utf8Value(val));
+ return base::MakeUnique<base::Value>(*v8::String::Utf8Value(val));
}
// v8::Value doesn't have a ToArray() method for some reason.
« no previous file with comments | « content/browser/tracing/tracing_ui.cc ('k') | content/child/v8_value_converter_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698