components/translate/core/browser/translate_prefs.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_prefs.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/translate/core/browser/translate_prefs.cc

diff --git a/components/translate/core/browser/translate_prefs.cc b/components/translate/core/browser/translate_prefs.cc

index 31955ad7073fabc4ec0306aeec07375a94e71a29..a61cb1eeddf6413d39b5ea47111205c99f958ce6 100644

--- a/components/translate/core/browser/translate_prefs.cc

+++ b/components/translate/core/browser/translate_prefs.cc

@@ -568,7 +568,7 @@ void TranslatePrefs::RemoveValueFromBlacklist(const char* pref_id,

NOTREACHED() << "Unregistered translate blacklist pref";

return;

}

- base::StringValue string_value(value);

+ base::Value string_value(value);

blacklist->Remove(string_value, NULL);

}