components/autofill/content/renderer/renderer_save_password_progress_logger.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/renderer_save_password_progress_logger.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/arc/bluetooth/bluetooth_type_converters_unittest.cc ('k') | components/autofill/core/common/save_password_progress_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/renderer_save_password_progress_logger.cc

diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger.cc b/components/autofill/content/renderer/renderer_save_password_progress_logger.cc

index bd71dbc0d88eb6ba13b51936df3db014e0a4ec64..36155261426007b634d27e8a86b795d5ba14fdae 100644

--- a/components/autofill/content/renderer/renderer_save_password_progress_logger.cc

+++ b/components/autofill/content/renderer/renderer_save_password_progress_logger.cc

@@ -25,8 +25,8 @@ void RendererSavePasswordProgressLogger::SendLog(const std::string& log) {

void RendererSavePasswordProgressLogger::LogElementName(

StringID label,

const blink::WebFormControlElement& element) {

- LogValue(label, base::StringValue(

- ScrubElementID((element.nameForAutofill().utf16()))));

+ LogValue(label,

+ base::Value(ScrubElementID((element.nameForAutofill().utf16()))));

}

} // namespace autofill